Compare commits

...

3 commits

Author SHA1 Message Date
Maarten
b0c3eca177 Fix usable hosts for other different subnets 2024-11-27 20:17:19 +01:00
Maarten
45c25fa5f3 Fix usable hosts for /32 subnet 2024-11-27 20:12:45 +01:00
Maarten
a763bf1d8c Refactor some if/else checks 2024-11-27 20:07:22 +01:00
5 changed files with 58 additions and 45 deletions

View file

@ -40,7 +40,27 @@ class Subnet
throw new Exception("CIDR must be between 0 and 32."); throw new Exception("CIDR must be between 0 and 32.");
} }
$hosts = (1 << (32 - $cidr)) - 2; // Excludes network and broadcast if ($cidr === 32) {
return [
'network' => $ip,
'first' => $ip,
'last' => $ip,
'hosts' => 1,
];
}
if ($cidr === 31) {
$ipLong = ip2long($ip);
$network = $ipLong & (-1 << (32 - $cidr));
return [
'network' => long2ip($network),
'first' => long2ip($network),
'last' => long2ip($network + 1),
'hosts' => 2,
];
}
$hosts = (1 << (32 - $cidr)) - 2;
$ipLong = ip2long($ip); $ipLong = ip2long($ip);
$mask = -1 << (32 - $cidr); $mask = -1 << (32 - $cidr);
$network = $ipLong & $mask; $network = $ipLong & $mask;
@ -56,6 +76,7 @@ class Subnet
]; ];
} }
/** /**
* Calculate IPv6 * Calculate IPv6
* *
@ -70,35 +91,50 @@ class Subnet
throw new Exception("CIDR must be between 0 and 128."); throw new Exception("CIDR must be between 0 and 128.");
} }
// Convert IP to binary representation if ($cidr === 128) {
$binaryIP = inet_pton($ip); return [
if ($binaryIP === false) { 'network' => $ip,
throw new Exception("Failed to parse IPv6 address."); 'first' => $ip,
'last' => $ip,
'hosts' => 1,
];
} }
// Calculate network address if ($cidr === 127) {
$binaryIP = inet_pton($ip);
$network = substr($binaryIP, 0, intval($cidr / 8));
$firstHost = inet_ntop($network);
$lastHost = inet_ntop($binaryIP);
return [
'network' => $firstHost,
'first' => $firstHost,
'last' => $lastHost,
'hosts' => 2,
];
}
// General case for other IPv6 subnets
$totalHosts = bcpow(2, 128 - $cidr); // Number of total IPs
$binaryIP = inet_pton($ip);
// Calculate the network address
$network = substr($binaryIP, 0, intval($cidr / 8)); $network = substr($binaryIP, 0, intval($cidr / 8));
$remainder = $cidr % 8; $remainder = $cidr % 8;
if ($remainder > 0) { if ($remainder > 0) {
$lastByte = ord($binaryIP[$cidr / 8]) & (0xFF << (8 - $remainder)); $lastByte = ord($binaryIP[intval($cidr / 8)]) & (0xFF << (8 - $remainder));
$network .= chr($lastByte); $network .= chr($lastByte);
} }
// Pad the rest with zeros
$network = str_pad($network, 16, "\0"); $network = str_pad($network, 16, "\0");
// Calculate first and last addresses
$networkAddress = inet_ntop($network); $networkAddress = inet_ntop($network);
$totalHosts = $cidr == 128 ? 1 : bcpow(2, 128 - $cidr);
$firstHost = ($cidr == 128) ? $networkAddress : inet_ntop($network);
$lastHost = inet_ntop(pack("H*", str_repeat("F", 32)));
return [ return [
'network' => $networkAddress, 'network' => $networkAddress,
'first' => $firstHost, 'first' => $cidr == 128 ? $networkAddress : inet_ntop($network),
'last' => $lastHost, 'last' => $cidr == 128 ? $networkAddress : inet_ntop($network), // Adjusted for simplicity
'hosts' => $totalHosts, 'hosts' => $totalHosts,
]; ];
} }
} }

View file

@ -10,7 +10,8 @@
"require": { "require": {
"php": ">=8.3.0", "php": ">=8.3.0",
"filp/whoops": "^2.16", "filp/whoops": "^2.16",
"vlucas/phpdotenv": "^5.6" "vlucas/phpdotenv": "^5.6",
"ext-bcmath": "*"
}, },
"require-dev": { "require-dev": {
"symfony/var-dumper": "^7.1", "symfony/var-dumper": "^7.1",

View file

@ -15,14 +15,11 @@ class HtmlEngine extends Render
$basePath = $_SERVER['DOCUMENT_ROOT']; $basePath = $_SERVER['DOCUMENT_ROOT'];
$viewsPath = app()->resourcePath('views/' . str_replace('.', '/', $this->view) . '.php'); $viewsPath = app()->resourcePath('views/' . str_replace('.', '/', $this->view) . '.php');
if (file_exists($viewsPath)) { if (!file_exists($viewsPath)) {
extract($this->data); throw new \Exception('View not found');
include $viewsPath;
return;
} }
throw new \Exception('View not found'); extract($this->data);
include $viewsPath;
} }
} }

View file

@ -71,6 +71,7 @@ class RouteCollection
fn($key) => !is_numeric($key), fn($key) => !is_numeric($key),
ARRAY_FILTER_USE_KEY ARRAY_FILTER_USE_KEY
); );
return $route; return $route;
} }
} }

View file

@ -1,22 +0,0 @@
<?php
namespace Core\Routing;
use Core\Http\Request;
class Router
{
/**
* Dispatch router and run application
*
* @return void
*/
public static function dispatch(): void
{
// Create request
$request = new Request($_POST + $_FILES);
// Dispatch router
RouteDispatcher::dispatch($request, RouteCollection::retrieve());
}
}